fix: include all relevant dormitory info in grouped answers(생활관 미지정 답변의 생활관별 정보 누락 개선)#34
Merged
1024andrew merged 1 commit intodevfrom May 4, 2026
Merged
fix: include all relevant dormitory info in grouped answers(생활관 미지정 답변의 생활관별 정보 누락 개선)#341024andrew merged 1 commit intodevfrom
1024andrew merged 1 commit intodevfrom
Conversation
Contributor
Author
|
프롬프트만 고친거라 그냥 머지했습니다 |
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the prompt instructions in app/services/generator.py to ensure that information for multiple dormitories is comprehensively reported, including cases where specific facilities are missing. A minor whitespace change was also introduced in app/services/chat_service.py. Feedback suggests that these new instructions may conflict with an existing directive to be concise and avoid forced distinctions, recommending that the existing instruction be updated to ensure clarity when dormitory information differs.
Comment on lines
+67
to
+68
| 질문에서 생활관을 특정하지 않았고 참고 정보에 여러 생활관의 정보가 포함되어 있으면, 확인된 생활관별 정보를 누락하지 말고 함께 안내해라. | ||
| 특정 생활관에 해당 시설이 없다는 정보가 참고 정보에 있으면 그 내용도 함께 안내해라. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
유형
수정 사항
수정 배경
dormitory = null상태에서다리미 있어?질문 시 검색 결과에는 제1학생생활관, 제2학생생활관, 제3학생생활관 관련 정보가 포함되어 있었지만, 답변은 제2학생생활관 정보만 안내하는 문제가 있었습니다.검색 결과 자체는 정상적으로 들어왔기 때문에, 검색 개수를 늘리기보다 답변 생성 단계에서 여러 생활관 정보를 누락하지 않도록 프롬프트를 보강했습니다.
테스트
다리미 있어?+dormitory = null기대 효과
스크린샷